Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online punctuation and casing prediction model for English language #1224

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

frankyoujian
Copy link
Contributor

For anyone who wants to add punctuation and casing to the raw text output of online ASR.

The quantized model is only 7MB, which is suitable for online ASR on edge devices.

Copy link
Collaborator

@csukuangfj csukuangfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some minor comments. Otherwise, it looks great to me.

sherpa-onnx/csrc/online-cnn-bilstm-model.cc Outdated Show resolved Hide resolved
sherpa-onnx/csrc/online-punctuation-cnn-bilstm-impl.h Outdated Show resolved Hide resolved
sherpa-onnx/csrc/online-punctuation-cnn-bilstm-impl.h Outdated Show resolved Hide resolved
sherpa-onnx/csrc/online-punctuation-model-config.cc Outdated Show resolved Hide resolved
sherpa-onnx/csrc/online-punctuation-cnn-bilstm-impl.h Outdated Show resolved Hide resolved
sherpa-onnx/csrc/online-punctuation-cnn-bilstm-impl.h Outdated Show resolved Hide resolved
sherpa-onnx/csrc/online-punctuation-cnn-bilstm-impl.h Outdated Show resolved Hide resolved
sherpa-onnx/csrc/sherpa-onnx-online-punctuation.cc Outdated Show resolved Hide resolved
@frankyoujian
Copy link
Contributor Author

frankyoujian commented Aug 6, 2024

@csukuangfj Have updated fix according to your comments.

@csukuangfj
Copy link
Collaborator

Could you fix the build error for android? Please see
https://github.com/k2-fsa/sherpa-onnx/actions/runs/10263762961/job/28396308494?pr=1224#step:4:2535

I think you have missed to include a header file.

@frankyoujian
Copy link
Contributor Author

Update a fix, hoping it can fix Android build.

@csukuangfj
Copy link
Collaborator

Thank you for your contribution!

@csukuangfj csukuangfj merged commit 1414e4d into k2-fsa:master Aug 6, 2024
141 of 192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants